-
-
Notifications
You must be signed in to change notification settings - Fork 172
Draft
Conversation
This reverts commit 222e477.
...eping both local shell-empty docs and remote accordion component
a-gonzalo
commented
Nov 30, 2025
Contributor
Author
lovasoa
commented
Nov 30, 2025
Collaborator
Hi !
Thanks for taking a stab at this !
This is a large PR and I am currently quite busy so it may take some time, but here are my initial remarks:
- we need a single well tested and well documented feature per PR
- in this case we need tests that exercise upload / download against an open source s3 implementation
- the ci times should not increase too much
- adding new dependencies is costly, we need some reassurance about: compiled binary size increase, compile time increase, how well the dependencies are maintained
- the documentation needs to be available on the official site
- i'm not a huge fan of interpreting the same argument as either a file path or a base64 string. If a file has a name that is a valid base64 string, it can get uploaded instead of base64 data.
- no custom bespoke security rules. I don't think we should forbid uploading files outside the web root. On the contrary it should be encouraged.
- I think the user should be able to upload to different buckets let them provide
s3://{bucket}/{key}, not just key.
kryskool
commented
Dec 3, 2025
Contributor
Hi @a-gonzalo
Instead of MinIO (MinIO just move in maintenance mode ) , maybe we can use RustFS
Regards,
lovasoa
commented
Dec 4, 2025
Collaborator
I'm not sure RustFS is production-ready...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #1120 .
Pending to test and document. First try.
Also, like 1 year ago I started working on an accordion component. I think I didn't make a pull request and I don't know if someone implemented it. I'll check it out and remove the changes if it is done.