-
Notifications
You must be signed in to change notification settings - Fork 11
Open
Conversation
memory_get(hash) returns the full dbmem_content row (hash, path, context, value, created_at, last_accessed) for a given content hash from search results. memory_query(query) executes an arbitrary SELECT against the memory database. Read-only safety is enforced at the SQLite engine level via PRAGMA query_only=ON on a dedicated connection, rather than a string-prefix check. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
memory_get(hash)— returns the fulldbmem_contentrow for a content hash from search results:hash,path,context,value,created_at,last_accessed. Useful whenmemory_searchsnippets are too short.memory_query(query)— executes an arbitrary SELECT against the memory database. Read-only enforcement viaPRAGMA query_only = ONon a dedicated connection (SQLite engine-level, not string matching).Test plan
TestGetReturnsFullContent— inserts a row, verifies all fields appear in JSON outputTestGetNotFound— verifies error returned for missing hashTestQuerySelectWorks— verifies SELECT returns expected rows as JSONTestQueryRejectsWrites— verifies INSERT fails underquery_onlyTestToolNames— updated to include both new toolsTestToolsListMapping— count check still passes (tools/list matches ToolNames)All 11 tests pass:
go test ./internal/memory/... ./internal/mcp/...🤖 Generated with Claude Code