-
Notifications
You must be signed in to change notification settings - Fork 943
fix(engine/sqlite): added json_tree and json_each definitions #4054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c228645 to
03a1e5f
Compare
03a1e5f to
8186938
Compare
@alixinne I have some larger plans for the SQLite engine that give us support for these features automatically. That means I'm going to hold off on reviewing / merging this right now. Thanks for understanding.
@alixinne I have some larger plans for the SQLite engine that give us support for these features automatically. That means I'm going to hold off on reviewing / merging this right now. Thanks for understanding.
That's good news, is there some kind of tracking issue for this I could subscribe to in order to follow along?
Uh oh!
There was an error while loading. Please reload this page.
fix #1830
This is a rebased version of @orisano's PR #2570. I've hit the same bug, and the fix in the PR does work in my case. I have removed the PostgreSQL tests changes as they look obsolete / not affected by the bugfix, so it's only focused on the sqlite code generation.
cc. @andrewmbenton and/or @kyleconroy for a review?