-
Notifications
You must be signed in to change notification settings - Fork 927
bugfix: Normalize identifier usage for table names #4045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: Normalize identifier usage for table names #4045
Conversation
Tests would be ideal. @kyleconroy may feel differently but I think because we already have an endtoend test for drop table statements it would be reasonable to just add a couple of statements to that test to cover this case.
As for the other failure cases, those are a bit more complicated and would require their own endtoend tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding tests.
Addressing issue #3936
Do you want to add tests for these? Thought would be a very specific test, so didn't add.
Let me know about the thoughts for this
Thanks