-
Notifications
You must be signed in to change notification settings - Fork 925
fix(compiler): insert-with-select statements #4006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dennisgsmith
wants to merge
1
commit into
sqlc-dev:main
from
dennisgsmith:dennisgsmith/fix-insert-cte-select-compiler-error
Open
fix(compiler): insert-with-select statements #4006
dennisgsmith
wants to merge
1
commit into
sqlc-dev:main
from
dennisgsmith:dennisgsmith/fix-insert-cte-select-compiler-error
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ct queries (all engines)
@dosubot
dosubot
bot
added
size:XL
This PR changes 500-999 lines, ignoring generated files.
🔧 golang
labels
Jun 30, 2025
@kyleconroy could you please review this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Fixes #3847
Fixes #3996
I was bumping into the above issues (but for postgres) and this bug seemed to be engine agnostic. After inspecting the output with
SQLCDEBUG=dumpast=1andSQLCDEBUG=dumpcatalog=1I found that:WithClausewas under theSelectStmt, not directly within the parentInsertStmtnode.Using the
SelectStmtWithClausewhen it's not null resolves the issue. Please let me know if there are any changes you'd like to see. Thanks!