Avoid updating target file mtime in 'generate' #3980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

n-oden wants to merge 1 commit into sqlc-dev:main

from odenio:preserve-target-mtime

Open

Avoid updating target file mtime in 'generate' #3980

n-oden wants to merge 1 commit into sqlc-dev:main from odenio:preserve-target-mtime

Conversation

n-oden

Copy link

@n-oden n-oden commented Jun 3, 2025

If the target file exists on disk already, compare its contents to the generated source in memory: only update the target file on disk if the contents differ or if the target file is missing.

This should allow build tools downstream of sqlc to make conditional decisions based on whether the generated code files have been updated (e.g. mockgen).

@dosubot dosubot bot added size:S 🔧 golang labels

Jun 3, 2025

@n-oden


 Avoid updating target file mtime in 'generate'

916bfbf

If the target file exists on disk already, compare its contents
to the generated source in memory: only update the target file
on disk if the contents differ or if the target file is missing.
This should allow build tools downstream of sqlc to make conditional
decisions based on whether the generated code files have been updated
(e.g. mockgen).