-
Notifications
You must be signed in to change notification settings - Fork 925
Fix ORDER BY arg parsing in sqlite
#3962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
+289
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dosubot
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
🔧 golang
labels
May 14, 2025
currently, base behavior works but mixing params like so:
-- name: ListAuthorsColumnSortDirection :many SELECT * FROM authors WHERE id > ? ORDER BY CASE WHEN @order_by = 'asc' THEN name END ASC, CASE WHEN @order_by = 'desc' OR @order_by IS NULL THEN name END DESC;
produces this incorrect output (question marks in CASE clauses should instead be same variable)
-- name: ListAuthorsColumnSortDirection :many SELECT id, name, bio FROM authors WHERE id > ? ORDER BY CASE WHEN ? = 'asc' THEN name END ASC, CASE WHEN ? = 'desc' OR ? IS NULL THEN name END DESC
this can still be worked around by using named params in this case.
@andriygm
andriygm
changed the title
(削除) Fix
(追記) Fix May 16, 2025
ORDER BY clause in sqlite (削除ここまで)ORDER BY arg parsing in sqlite (追記ここまで)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
sqlccurrently doesn't handle boundORDER BYclauses in sqlite, nor does it have tests for this behavior. This PR attempts for rectify this. Closes #3788.