-
Notifications
You must be signed in to change notification settings - Fork 925
chore: use any in place of interface{}
#3961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dosubot
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
🔧 golang
labels
May 13, 2025
@snprajwal
snprajwal
force-pushed
the
use-any
branch
from
May 13, 2025 15:09
43c89b0 to
f705a2b
Compare
@dosubot
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
and removed
size:M
This PR changes 30-99 lines, ignoring generated files.
labels
May 13, 2025
@snprajwal
snprajwal
force-pushed
the
use-any
branch
from
May 13, 2025 15:47
f705a2b to
f0a3c63
Compare
Interesting, it looks like the generated names for constants are not escaped
Also adds `any` as a reserved keyword, as it was introduced in Go 1.18. Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
@snprajwal
snprajwal
force-pushed
the
use-any
branch
from
May 13, 2025 16:22
f0a3c63 to
7ae311a
Compare
@kyleconroy I just realised this might be noisier than needed, since the linter ignores generated files. Would you want me to split the bug fix out into a separate PR and close this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This addresses the lint raised by gopls on sqlc's generated Go files for modernizing the usage of an empty interface for the
anytype.