-
Notifications
You must be signed in to change notification settings - Fork 925
allow renaming function Params structs #3878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any chance this can be merged, or feedback on what it would take?
@skandragon
skandragon
force-pushed
the
rename-params
branch
from
April 1, 2025 20:33
92394a9
to
567d8bd
Compare
@skandragon
skandragon
force-pushed
the
rename-params
branch
from
June 6, 2025 04:49
567d8bd
to
7242e00
Compare
bump.
@skandragon
skandragon
force-pushed
the
rename-params
branch
from
August 3, 2025 05:04
7242e00
to
7a2d750
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a case where I want to wrap some of the database calls in some internal layers, and would like to have a single params structure that is exposed between my hand-rolled wrapped code and the generated names.
Specifically, I am making a function called
UpsertFooUncached
using code gen and I want a cached version:In this case, I could use
type UpsertFooParams UpsertFooUncachedParams
but this doesn't work well for users as it doesn't always expand with VSCode, so the internals are a mystery. I could recreate the structure, but then I need to keep it in sync. I could embed the Uncached version, but then using it is a pain.I'd like to rename, and this change seems to do the trick.