-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add support for es module and browser-only environment #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change prevents webpack and other junk from doing errors like: https://stackoverflow.com/questions/59487224/webpack-throws-error-with-emscripten-cant-resolve-fs Other notes: https://esbuild.github.io/api/#main-fields-for-package-authors
This was tricky to figure out. Using the ENVIRONMENT=web flag for the browser build started causing prepared statements to fail - it would behave as if no params were passed to db.exec("...", []) as the second arg. It turns out that the closure compiler was removing the bind() call.. It's not clear to me why, but adding externs that map out the exported structure fixes the issue. Some other notes: - emscripten runs with ADVANCED mode for closure compiler - closure compiler reuses variables... - use --closure-args=--debug and --closure-args=--pretty-print for clues
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #284.
I've tested this change using the current
create-react-app
along with this webpack config: