-
Notifications
You must be signed in to change notification settings - Fork 38.7k
Refactor doGetBeanNamesForType for improved readability and performance #35503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+81
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...iew of the jit compilor Signed-off-by: KNU-K <knukang334@gmail.com>
@polyglot-k
polyglot-k
force-pushed
the
main
branch
from
September 18, 2025 15:42
f1a4559
to
f7f164f
Compare
@spring-projects-issues
spring-projects-issues
added
the
status: waiting-for-triage
An issue we've not yet triaged or decided on
label
Sep 18, 2025
Signed-off-by: KNU-K <knukang334@gmail.com>
@polyglot-k
polyglot-k
force-pushed
the
main
branch
from
September 18, 2025 15:47
3ca04b5
to
2ab2869
Compare
Signed-off-by: KNU-K <knukang334@gmail.com>
Signed-off-by: KNU-K <knukang334@gmail.com>
Signed-off-by: KNU-K <knukang334@gmail.com>
Signed-off-by: KNU-K <knukang334@gmail.com>
Signed-off-by: KNU-K <knukang334@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
PR Description:
This pull request refactors the logic for collecting bean names by type in
DefaultListableBeanFactory
to improve readability and maintainability. The main change is splitting the logic into two helper methods: one for processing bean definitions and another for processing manually registered singletons. This makes the code easier to follow and maintain, without altering its functionality.Refactoring and code organization:
processBeanDefinitions
(handles bean definitions) andprocessManualSingletons
(handles manually registered singletons), improving separation of concerns and code readability.Error handling improvements:
Note
This helps with hot path configuration at the jit computer level.
Thank you for reviewing this PR! Your feedback is highly appreciated.