Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Avoid thread pinning in SseEmitter, ResponseBodyEmitter #35423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acktsap wants to merge 1 commit into spring-projects:main
base: main
Choose a base branch
Loading
from acktsap:topic/sse-thread-pinning

Conversation

Copy link
Contributor

@acktsap acktsap commented Sep 4, 2025

Closes gh-35422

* @since 4.2
*/
public class SseEmitter extends ResponseBodyEmitter {

private static final MediaType TEXT_PLAIN = new MediaType("text", "plain", StandardCharsets.UTF_8);

/** Guards access to write operations on the response. */
private final Lock writeLock = new ReentrantLock();
Copy link
Contributor Author

@acktsap acktsap Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just moved this field to the upper level & changed it to protected

Copy link
Member

bclozel commented Sep 4, 2025

@acktsap please run the build locally before submitting a PR: ./gradlew check.
You can then git push --force to your branch to update this PR.

@acktsap acktsap force-pushed the topic/sse-thread-pinning branch from f9a40be to ebce252 Compare September 4, 2025 15:51
Copy link
Contributor Author

acktsap commented Sep 4, 2025

@acktsap please run the build locally before submitting a PR: ./gradlew check. You can then git push --force to your branch to update this PR.

Completed
bclozel reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: waiting-for-triage An issue we've not yet triaged or decided on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid pinning in SSEEmitter & ResponseBodyEmitter

AltStyle によって変換されたページ (->オリジナル) /