-
Notifications
You must be signed in to change notification settings - Fork 38.7k
class level support for @JsonView in JsonViewResponseBodyAdvice #35350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@spring-projects-issues
spring-projects-issues
added
the
status: waiting-for-triage
An issue we've not yet triaged or decided on
label
Aug 19, 2025
This commit also includes related refinements of JdbcTemplate#getSingleColumnRowMapper and ObjectUtils#addObjectToArray. Closes spring-projectsgh-35340
@asifebrahim
asifebrahim
force-pushed
the
main
branch
from
August 19, 2025 17:07
aa64149 to
f4bd0e5
Compare
@bclozel
bclozel
added
status: invalid
An issue that we don't feel is valid
and removed
status: waiting-for-triage
An issue we've not yet triaged or decided on
labels
Aug 19, 2025
Hey @asifebrahim, I am not sure to understand why you closed this PR which seems to fix #35343 before we had a chance to review it. Could you explain?
i thought someone else was assigned to it so that's why..I'll reopen
quaff
quaff
reviewed
Aug 21, 2025
return super.supports(returnType, converterType) && returnType.hasMethodAnnotation(JsonView.class);
return super.supports(returnType, converterType) &&
(returnType.hasMethodAnnotation(JsonView.class) ||
returnType.getDeclaringClass().isAnnotationPresent(JsonView.class));
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should @JsonView on super type be considered?
@sdeleuze
sdeleuze
added
in: web
Issues in web modules (web, webmvc, webflux, websocket)
type: enhancement
A general enhancement
and removed
status: invalid
An issue that we don't feel is valid
labels
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Made the necessary changes with a test file
Closes 35343
Signed-off-by: Asif Ebrahim asifebrahim13@gmail.com