-
Notifications
You must be signed in to change notification settings - Fork 368
Migrate to JSpecify annotations for nullability constraints #2126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace nullability annotations with their JSpecify equivalents. Enable checking this annotations at compile time using Errorprone and NullAway. Closes #1980
mp911de
mp911de
reviewed
Sep 2, 2025
@@ -42,64 +42,41 @@
*/
public interface DbAction<T> {
Class<T> getEntityType();
Class<T> entityType();
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DbAction is a public API. We should not introduce breaking changes without deprecation. Was this change intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is absolutely an accident.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fixed.
RelationalEntityWriterUnitTests.cascadingReferencesTriggerCascadingActions fails with:
org.opentest4j.AssertionFailedError:
Expecting actual:
[(org.springframework.data.relational.core.conversion.DbAction.InsertRoot, org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.CascadingReferenceEntity, "", org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.CascadingReferenceEntity, false, GENERATED),
(org.springframework.data.relational.core.conversion.DbAction.Insert, org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.CascadingReferenceMiddleElement, "other", org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.CascadingReferenceMiddleElement, true, GENERATED),
(org.springframework.data.relational.core.conversion.DbAction.Insert, org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.CascadingReferenceMiddleElement, "other", org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.CascadingReferenceMiddleElement, true, GENERATED),
(org.springframework.data.relational.core.conversion.DbAction.Insert, org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.Element, "other.element", org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.Element, true, GENERATED),
(org.springframework.data.relational.core.conversion.DbAction.Insert, org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.Element, "other.element", org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.Element, true, GENERATED)]
to contain exactly (and in same order):
[(org.springframework.data.relational.core.conversion.DbAction.InsertRoot, org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.CascadingReferenceEntity, "", org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.CascadingReferenceEntity, false, GENERATED),
(org.springframework.data.relational.core.conversion.DbAction.Insert, org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.CascadingReferenceMiddleElement, "other", org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.CascadingReferenceMiddleElement, true, GENERATED),
(org.springframework.data.relational.core.conversion.DbAction.Insert, org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.CascadingReferenceMiddleElement, "other", org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.CascadingReferenceMiddleElement, true, GENERATED),
(org.springframework.data.relational.core.conversion.DbAction.Insert, org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.Element, "other.element", org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.Element, true, GENERATED),
(org.springframework.data.relational.core.conversion.DbAction.Insert, org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.Element, "other.element", org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.Element, true, GENERATED),
(org.springframework.data.relational.core.conversion.DbAction.Insert, org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.Element, "other.element", org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.Element, true, GENERATED),
(org.springframework.data.relational.core.conversion.DbAction.Insert, org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.Element, "other.element", org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.Element, true, GENERATED)]
but could not find the following elements:
[(org.springframework.data.relational.core.conversion.DbAction.Insert, org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.Element, "other.element", org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.Element, true, GENERATED),
(org.springframework.data.relational.core.conversion.DbAction.Insert, org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.Element, "other.element", org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.Element, true, GENERATED)]
Expected :[(org.springframework.data.relational.core.conversion.DbAction.InsertRoot, org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.CascadingReferenceEntity, "", org.springframework.data.relational.core.conversion.Relationa ...
Actual :[(org.springframework.data.relational.core.conversion.DbAction.InsertRoot, org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.CascadingReferenceEntity, "", org.springframework.data.relational.core.conversion.Relationa ...
<Click to see difference>
at org.springframework.data.relational.core.conversion.RelationalEntityWriterUnitTests.cascadingReferencesTriggerCascadingActions(RelationalEntityWriterUnitTests.java:332)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
and two other test methods in the same class. Care to have a look?
Refine nullability annotation formatting, reduce warnings (final fields, isEmpty vs. length() == null), introduce getRequired...() methods to avoid Assert sprawl. Convert internal classes to records. Fix generic types (refactoring leftovers). Replace package-info imports with fully-qualified annotation name to align formatting.
@mp911de
mp911de
changed the title
(削除) Migrate to JSpecify annotations for nullability constraints. (削除ここまで)
(追記) Migrate to JSpecify annotations for nullability constraints (追記ここまで)
Sep 2, 2025
a class used in the tests was converted to records. The problem: It was used in a set and the equals/hashCode implementation of record made all instances the same.
RelationalEntityWriterUnitTests.cascadingReferencesTriggerCascadingActionsfails with:
...
and two other test methods in the same class. Care to have a look?
That's fixed. A conversion to record made instances in a Set identical. Reverted the change.
mp911de
pushed a commit
that referenced
this pull request
Sep 4, 2025
mp911de
added a commit
that referenced
this pull request
Sep 4, 2025
Refine nullability annotation formatting, reduce warnings (final fields, isEmpty vs. length() == null), introduce getRequired...() methods to avoid Assert sprawl. Convert internal classes to records. Fix generic types (refactoring leftovers). Replace package-info imports with fully-qualified annotation name to align formatting. See #1980 Original pull request: #2126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Replace nullability annotations with their JSpecify equivalents.
Enable checking this annotations at compile time using Errorprone and NullAway.
Closes #1980