-
Notifications
You must be signed in to change notification settings - Fork 367
Use JDBCType.NULL for null if possible #2069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Not all databases support the JDBCSqlType.NULL. Therefore this handling was made dialect dependent, with SQL Server and DB2 using the old approach, while all others use JDBCSqlType.NULL In the process modified AbstractJdbcConfiguration to use JdbcDialect instead of Dialect. Original pull request #2068 See #1935 See #2031
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have more meaningful names. Something like NULL_VALUE instead of DEFAULT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite sure this is the best way to approach the problem because we're introducing configuration complexity on our side how to massage the JDBC driver.
In R2DBC, we've solved the issue of writing null values by considering these in the SQL statement using NULL instead of a parameter bind marker. That seems much easier than figuring out (and potentially asking the database to obtain) a SQL type number for a null value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤣
Uh oh!
There was an error while loading. Please reload this page.
This is based on #2068.
Not all databases support the JDBCSqlType.NULL.
Therefore this handling was made dialect dependent, with SQL Server and DB2 using the old approach, while all others use JDBCSqlType.NULL
In the process modified AbstractJdbcConfiguration to use JdbcDialect instead of Dialect.
Closes #1935