Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

breaking change for @Lock on String methods #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mipo256 wants to merge 1 commit into spring-projects:main from mipo256:lock-string-bc

Conversation

Copy link
Contributor

@mipo256 mipo256 commented Apr 1, 2025

This PR completes the discussion here, but is a breaking change anyway, so I decided to clean up some APIs that were for removal anywhay.

 

Signed-off-by: mipo256 <mikhailpolivakha@gmail.com>
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

spring-data-jdbc/src/main/java/org/springframework/data/jdbc/repository/query/StringBasedJdbcQuery.java:149

  • Replacing a warning with an exception for unsupported @lock usage is a breaking change. Ensure that clients invoking this API update to handle this exception and consider adding tests or documentation to clarify the new behavior.
throw new UnsupportedOperationException(LOCKING_IS_NOT_SUPPORTED + queryMethod);

Copy link
Member

mp911de commented Apr 8, 2025

Don't be scared, I requested out of interest a review from GitHub's copilot to see what happens. I never tried that so treat it as experiment.
mipo256 reacted with thumbs up emoji

@mp911de mp911de force-pushed the main branch 2 times, most recently from 571fd96 to 1f2e694 Compare April 9, 2025 13:29
schauder added a commit that referenced this pull request Apr 10, 2025 
Formatting.
Added a test.
Original pull request #2023
See #2008
Copy link
Contributor

schauder commented Apr 10, 2025 •
edited
Loading

Thanks. That's merged in 4.0.x
mipo256 reacted with thumbs up emoji

@schauder schauder added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 10, 2025
@schauder schauder added this to the 4.0 M2 (202510) milestone Apr 10, 2025
schauder added a commit that referenced this pull request Apr 25, 2025 
Formatting.
Added a test.
Original pull request #2023
See #2008
schauder added a commit that referenced this pull request May 12, 2025 
Formatting.
Added a test.
Original pull request #2023
See #2008
mp911de pushed a commit that referenced this pull request May 16, 2025 
Formatting.
Added a test.
Original pull request #2023
See #2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /