-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add support for Redis SINTERCARD command #3210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Kiminni
wants to merge
12
commits into
spring-projects:main
from
Kiminni:feature/add-sintercard-operations
Closed
Add support for Redis SINTERCARD command #3210
Kiminni
wants to merge
12
commits into
spring-projects:main
from
Kiminni:feature/add-sintercard-operations
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@spring-projects-issues
spring-projects-issues
added
the
status: waiting-for-triage
An issue we've not yet triaged
label
Aug 31, 2025
Signed-off-by: Kiminni <imk0980@gmail.com>
Signed-off-by: Kiminni <imk0980@gmail.com>
Signed-off-by: Kiminni <imk0980@gmail.com>
Signed-off-by: Kiminni <imk0980@gmail.com>
...etCommands Signed-off-by: Kiminni <imk0980@gmail.com>
...nsIntegrationTests Signed-off-by: Kiminni <imk0980@gmail.com>
@Kiminni
Kiminni
force-pushed
the
feature/add-sintercard-operations
branch
from
August 31, 2025 10:47
ac54149 to
4fc1965
Compare
@mp911de
mp911de
added
type: enhancement
A general enhancement
and removed
status: waiting-for-triage
An issue we've not yet triaged
labels
Sep 1, 2025
onobc
onobc
requested changes
Sep 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the excellent contribution @Kiminni.
I believe there are still a few places to add the new API to:
RedisSet/DefaultRedisSet/DefaultRedisZSetBoundSetOperations- the Reactive counterparts
src/main/java/org/springframework/data/redis/connection/RedisSetCommands.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kiminni <imk0980@gmail.com>
Signed-off-by: Kiminni <imk0980@gmail.com>
Signed-off-by: Kiminni <imk0980@gmail.com>
...OperationsIntegrationTests Signed-off-by: Kiminni <imk0980@gmail.com>
Signed-off-by: Kiminni <imk0980@gmail.com>
Signed-off-by: Kiminni <imk0980@gmail.com>
Hello, @onobc.
I’ve applied the requested changes and addressed the review feedback.
Please review again and let me know if there are any remaining issues or further adjustments needed.
Thank you!
onobc
pushed a commit
that referenced
this pull request
Oct 2, 2025
This commit adds support for Redis 7.0+ SINTERCARD command in Spring Data Redis. The `sInterCard` API has been added to SetCommands and ClusterSetCommands for both Jedis and Lettuce. The high-level `intersectSize` API has been added to SetOperations implementations as well. Original Pull Request: #3210 Resolves: #2906 Signed-off-by: Kiminni <imk0980@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements support for Redis 7.0+ SINTERCARD command in Spring Data Redis.
Fixes #2906
Changes
Core Implementation
sInterCardmethod toRedisSetCommandsinterfacesInterCardinJedisSetCommandsusing Jedis clientsInterCardinLettuceSetCommandsusing Lettuce clientCluster Support
sInterCardinJedisClusterSetCommandssInterCardinLettuceClusterSetCommandsConnection Wrappers
sInterCarddelegation inDefaultedRedisConnectionsInterCardsupport inStringRedisConnectionDefaultStringRedisConnectionHigh-Level API
intersectSizemethods toSetOperationsintersectSizeinDefaultSetOperationsTesting
Comprehensive integration tests with
@EnabledOnCommand("SINTERCARD")Test coverage for all connection types (Jedis, Lettuce, Cluster)
Various intersection scenarios (empty, partial, full)
You have read the Spring Data contribution guidelines.
You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
You submit test cases (unit or integration tests) that back your changes.
You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).