Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add allow cache configuration from file #3059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Copy link

@chaelink chaelink commented Nov 30, 2024

Fixes #1510

This PR adds the functionality to read cache configuration from a properties file. A global (default) configuration file, redis-cache.properties, has been implemented as the first step.

As a future enhancement, I plan to add support for additional individual cache configuration files, such as person.redis-cache.properties, as mentioned in the issue, which can override the defaults.

If you have any suggestions or ideas for implementing this enhancement, please feel free to share!

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

injae-kim reacted with thumbs up emoji injae-kim reacted with heart emoji injae-kim reacted with rocket emoji
Copy link

@chaelink Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

Copy link

@chaelink Thank you for signing the Contributor License Agreement!

@mp911de mp911de added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 15, 2025
Copy link
Member

mp911de commented Jan 15, 2025

Thanks for looking into that topic. We do not want to add complexity on that end, see #1510 (comment) for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow cache configuration from file [DATAREDIS-938]

AltStyle によって変換されたページ (->オリジナル) /