-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add allow cache configuration from file #3059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
chaelink
wants to merge
1
commit into
spring-projects:main
from
chaelink:feature/redis-cache-file-config
Closed
Add allow cache configuration from file #3059
chaelink
wants to merge
1
commit into
spring-projects:main
from
chaelink:feature/redis-cache-file-config
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pivotal-cla
commented
Nov 30, 2024
@chaelink Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
@spring-projects-issues
spring-projects-issues
added
the
status: waiting-for-triage
An issue we've not yet triaged
label
Nov 30, 2024
pivotal-cla
commented
Nov 30, 2024
@chaelink Thank you for signing the Contributor License Agreement!
@mp911de
mp911de
added
status: declined
A suggestion or change that we don't feel we should currently apply
and removed
status: waiting-for-triage
An issue we've not yet triaged
labels
Jan 15, 2025
Thanks for looking into that topic. We do not want to add complexity on that end, see #1510 (comment) for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1510
This PR adds the functionality to read cache configuration from a properties file. A global (default) configuration file, redis-cache.properties, has been implemented as the first step.
As a future enhancement, I plan to add support for additional individual cache configuration files, such as person.redis-cache.properties, as mentioned in the issue, which can override the defaults.
If you have any suggestions or ideas for implementing this enhancement, please feel free to share!