Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

StreamMessageListenerContainer should wait for cancellation to complete on shutdown #3040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JiHongKim98 wants to merge 2 commits into spring-projects:main
base: main
Choose a base branch
Loading
from JiHongKim98:main

Conversation

Copy link

@JiHongKim98 JiHongKim98 commented Nov 11, 2024
edited
Loading

Fix issue: #2261

Referring to pull request #2563 , modified the logic to use CountDownLatch to wait for completion on cancel without busy-spin.

If there are any improvements or suggestions, please feel free to let me know.
Thank you for reviewing this pull request!

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

ej31, Namgyu11, moolmin, and ChaceYang reacted with rocket emoji
@mp911de mp911de self-assigned this Nov 11, 2024
@mp911de mp911de added the status: pending-design-work Needs design work before any code can be developed label Nov 11, 2024
Copy link
Author

@mp911de Would you mind sharing your thoughts on this PR when you have a chance? 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Labels
status: pending-design-work Needs design work before any code can be developed status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /