-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Migrate build to Spring Develocity Conventions extension #2947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mp911de
merged 2 commits into
spring-projects:main
from
erichaagdev:develocity-conventions
Aug 1, 2024
Merged
Migrate build to Spring Develocity Conventions extension #2947
mp911de
merged 2 commits into
spring-projects:main
from
erichaagdev:develocity-conventions
Aug 1, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@spring-projects-issues
spring-projects-issues
added
the
status: waiting-for-triage
An issue we've not yet triaged
label
Jul 26, 2024
@mp911de
mp911de
added
type: task
A general task
and removed
status: waiting-for-triage
An issue we've not yet triaged
labels
Aug 1, 2024
mp911de
added a commit
that referenced
this pull request
Aug 1, 2024
Remove lingering DEVELOCITY_CACHE credential declarations. Address typo. See #2947
mp911de
pushed a commit
that referenced
this pull request
Aug 1, 2024
* Migrate build to Spring Develocity Conventions extension. * Adopt Develocity environment variables. Closes #2947
mp911de
added a commit
that referenced
this pull request
Aug 1, 2024
Remove lingering DEVELOCITY_CACHE credential declarations. Address typo. See #2947
mp911de
pushed a commit
that referenced
this pull request
Aug 1, 2024
* Migrate build to Spring Develocity Conventions extension. * Adopt Develocity environment variables. Closes #2947
mp911de
added a commit
that referenced
this pull request
Aug 1, 2024
Remove lingering DEVELOCITY_CACHE credential declarations. Address typo. See #2947
Thank you for your contribution. That's merged, polished, and backported now.
Oops. I'm not sure how I missed those cache credentials. Thanks, @mp911de!
No worries, I'm going to fix these as I merge your PR's.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the build to use Spring's Develocity Conventions Maven extension.
https://github.com/spring-io/develocity-conventions
With this, explicit configuration of the Develocity Maven extension is no longer required, as all configuration is encapsulated within the Spring extension.
Additionally, build cache authentication now uses the Develocity access key, so separate build cache credentials are no longer required. The
DEVELOCITY_ACCESS_KEYenvironment variable is enough for both build scan publishing and remote build cache access.