-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ISSUE #2781 Jedis Port Resolving Support #2780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
+122
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pivotal-cla
commented
Nov 20, 2023
@anish8129 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
@spring-projects-issues
spring-projects-issues
added
the
status: waiting-for-triage
An issue we've not yet triaged
label
Nov 20, 2023
pivotal-cla
commented
Nov 20, 2023
@anish8129 Thank you for signing the Contributor License Agreement!
@anish8129
anish8129
changed the title
(削除) Jedis nat support (削除ここまで)
(追記) ISSUE #2781 Jedis Port Resolving Support (追記ここまで)
Nov 20, 2023
@mp911de
mp911de
added
type: enhancement
A general enhancement
and removed
status: waiting-for-triage
An issue we've not yet triaged
labels
Nov 27, 2023
Hi @mp911de can you please review this PR and suggest what needs to be changed here.
I will try to address them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Issue : #2781
Please suggest if I have missed anything in this as this is my first PR in this project.
Added support for handling the port resolving issues while running Redis Clusters in TestContainers.
This change is influenced from the blog and repo