Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add NOMKSTREAM option to XADD command #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
morenomjc wants to merge 1 commit into spring-projects:main from morenomjc:issue/2047

Conversation

Copy link
Contributor

@morenomjc morenomjc commented Jul 13, 2021

Closes #2047

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Copy link
Member

@mp911de mp911de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. I left a few comments, mostly highlevel aspects.

Also, you might want to update your email address used for the Git commits to connect these to your profile. Right now, the mail address in the Git commits doesn't match your Github profile.

Feel free to force-push all changes once you're done and leave a comment on the pull request once we should re-review.

Copy link
Contributor Author

morenomjc commented Jul 13, 2021 •
edited
Loading

Hi @mp911de pushed changes to resolve comments.

@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 14, 2021
@mp911de mp911de added this to the 2.6 M1 (202110) milestone Jul 14, 2021
mp911de pushed a commit that referenced this pull request Jul 14, 2021
mp911de added a commit that referenced this pull request Jul 14, 2021 
Switch Jedis XADD call to XAddParams.
See #2047
Original pull request: #2118.
Copy link
Member

mp911de commented Jul 14, 2021

Thank you for your contribution. That's merged and polished now.
morenomjc reacted with heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de mp911de requested changes

Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add NOMKSTREAM option to XADD command

AltStyle によって変換されたページ (->オリジナル) /