-
Notifications
You must be signed in to change notification settings - Fork 619
refactor: Migrate to JSpecify annotations for nullability constraints. #3016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Replaces all deprecated Spring annotations with JSpecify annotations, and includes a full refactor so that the parent build profile `-Pnullaway` compiles and works proper. Closes #2987 Signed-off-by: Michael Simons <michael@simons.ac>
Please enjoy each line individually or call for C&M to LGTM this away @meistermeier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add
^org\.springframework\.lang\.Nullable, ^org\.springframework\.lang\.NonNullApi, ^org\.springframework\.lang\.NonNull to the checkstyle's IllegalImportCheck. Just to be sure for the future and avoid importing deprecated API by accident.
I’ll do it in a second commit when migrating to Spring Format. Very good idea.
Replaces all deprecated Spring annotations with JSpecify annotations, and includes a full refactor so that the parent build profile
-Pnullawaycompiles and works proper.Closes #2987