-
Notifications
You must be signed in to change notification settings - Fork 619
bugfix: Multi Relationships cannot get right conversion type #2974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@spring-projects-issues
spring-projects-issues
added
the
status: waiting-for-triage
An issue we've not yet triaged
label
Nov 22, 2024
nvm the last commit. My github command line tool fooled me. But nothing to worry about :D
Sorry for the force pushes, wanted to get rid of the merge commit but also rebase on the current main branch to avoid potential merge problems in the future.
Signed-off-by: 杨耀飞 <yangyaofei@gmail.com> Signed-off-by: yangyaofei <yangyaofei@gmail.com>
Signed-off-by: 杨耀飞 <yangyaofei@gmail.com> Signed-off-by: yangyaofei <yangyaofei@gmail.com>
Signed-off-by: 杨耀飞 <yangyaofei@gmail.com> Signed-off-by: yangyaofei <yangyaofei@gmail.com>
...determ whether to persist type information Signed-off-by: 杨耀飞 <yangyaofei@gmail.com> Signed-off-by: yangyaofei <yangyaofei@gmail.com>
@meistermeier force-pushed with Signed-off, now check is passed
Signed-off-by: Gerrit Meier <meistermeier@gmail.com>
I added some changes. If you are happy with this, I will go ahead and squash/merge it.
Ignore the missing DCO commit right now.
@meistermeier it looks great, go ahead do it. And if there is anything I need to do tell me.
@meistermeier
meistermeier
merged commit Jan 23, 2025
7490d99
into
spring-projects:main
1 check failed
Thanks for the contribution 🙇
This is now merged to the main branch.
meistermeier
added a commit
that referenced
this pull request
Jan 27, 2025
Add an optional parameter to `@RelationshipProperties` that allows users to persist the type information on this relationship. This will allow SDN to detect the right class it needs to instantiate if, due to abstraction of the implementation, no other information is available. Closes #2973 Signed-off-by: 杨耀飞 <yangyaofei@gmail.com> Signed-off-by: yangyaofei <yangyaofei@gmail.com> Signed-off-by: Gerrit Meier <meistermeier@gmail.com> Co-authored-by: Gerrit Meier <meistermeier@gmail.com> (cherry picked from commit 7490d99)
meistermeier
added a commit
that referenced
this pull request
Jan 27, 2025
Add an optional parameter to `@RelationshipProperties` that allows users to persist the type information on this relationship. This will allow SDN to detect the right class it needs to instantiate if, due to abstraction of the implementation, no other information is available. Closes #2973 Signed-off-by: 杨耀飞 <yangyaofei@gmail.com> Signed-off-by: yangyaofei <yangyaofei@gmail.com> Signed-off-by: Gerrit Meier <meistermeier@gmail.com> Co-authored-by: Gerrit Meier <meistermeier@gmail.com> (cherry picked from commit 7490d99)
meistermeier
added a commit
that referenced
this pull request
Jan 28, 2025
Add an optional parameter to `@RelationshipProperties` that allows users to persist the type information on this relationship. This will allow SDN to detect the right class it needs to instantiate if, due to abstraction of the implementation, no other information is available. Closes #2973 Signed-off-by: 杨耀飞 <yangyaofei@gmail.com> Signed-off-by: yangyaofei <yangyaofei@gmail.com> Signed-off-by: Gerrit Meier <meistermeier@gmail.com> Co-authored-by: Gerrit Meier <meistermeier@gmail.com> (cherry picked from commit 7490d99)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #2973