Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

issue/2953 #2962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mkoertgen wants to merge 1 commit into spring-projects:main from mkoertgen:main
Closed

issue/2953 #2962

mkoertgen wants to merge 1 commit into spring-projects:main from mkoertgen:main

Conversation

Copy link
Contributor

@mkoertgen mkoertgen commented Oct 18, 2024

fixes #2953

Copy link
Collaborator

Thanks a lot. I hope to have a look later this week (🤞 )

mkoertgen reacted with thumbs up emoji

Copy link
Collaborator

Thanks again for this PR. I think it makes sense in this way, even though I am not completely happy with the syntax of readOnlyTxManager....(...., readOnly=true). It feels somehow like a duplication. On the other hand I see no way how the write-mode transaction manager in the executable query should know that it is about to join an ongoing transaction.

Something that is missing in the PR is the support for the reactive template manager (you're missing all the fun ;) )
Unfortunately there is no validate method on the reactive transaction manager that will help us (you) to verify that this is working, or I cannot find it right now.

Copy link
Contributor Author

Hi @meistermeier ,

Will add the reactive part. Thanks for reviewing 👍

Copy link
Contributor Author

Hi @meistermeier ,

As of now, AbstractReactiveTransactionManager does not support transactional validation as does AbstractPlatformTransactionManager.setValidateExistingTransaction.

So it does not make sense to add it now.

Copy link
Collaborator

Sorry to come back to this that late. Had a longer look at this today and I am happy with this change.
Could you please rebase/squash the commits and add the Sign-Off? (https://spring.io/blog/2025/01/06/hello-dco-goodbye-cla-simplifying-contributions-to-spring)

Copy link
Contributor Author

No problem. Will do 👍

Copy link
Contributor Author

There you go @meistermeier.

meistermeier reacted with thumbs up emoji

Signed-off-by: Gerrit Meier <meistermeier@gmail.com>
Signed-off-by: Marcel Körtgen <marcel.koertgen@gmail.com>
Copy link
Collaborator

Merged this PR to 8.0.x with 0bedafb and main (upcoming 7.5.x) with 5aa41e7
Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meistermeier meistermeier meistermeier left review comments

Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Neo4jTemplate.DefaultExecutableQuery.getSingleResult() always executes in non-readonly transaction

AltStyle によって変換されたページ (->オリジナル) /