-
Notifications
You must be signed in to change notification settings - Fork 619
issue/2953 #2962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue/2953 #2962
Conversation
Thanks a lot. I hope to have a look later this week (🤞 )
src/main/java/org/springframework/data/neo4j/core/Neo4jTemplate.java
Outdated
Show resolved
Hide resolved
Thanks again for this PR. I think it makes sense in this way, even though I am not completely happy with the syntax of readOnlyTxManager....(...., readOnly=true)
. It feels somehow like a duplication. On the other hand I see no way how the write-mode transaction manager in the executable query should know that it is about to join an ongoing transaction.
Something that is missing in the PR is the support for the reactive template manager (you're missing all the fun ;) )
Unfortunately there is no validate method on the reactive transaction manager that will help us (you) to verify that this is working, or I cannot find it right now.
Hi @meistermeier ,
Will add the reactive part. Thanks for reviewing 👍
Hi @meistermeier ,
As of now, AbstractReactiveTransactionManager does not support transactional validation as does AbstractPlatformTransactionManager.setValidateExistingTransaction.
So it does not make sense to add it now.
Sorry to come back to this that late. Had a longer look at this today and I am happy with this change.
Could you please rebase/squash the commits and add the Sign-Off? (https://spring.io/blog/2025/01/06/hello-dco-goodbye-cla-simplifying-contributions-to-spring)
No problem. Will do 👍
There you go @meistermeier.
Signed-off-by: Gerrit Meier <meistermeier@gmail.com> Signed-off-by: Marcel Körtgen <marcel.koertgen@gmail.com>
fixes #2953