-
Notifications
You must be signed in to change notification settings - Fork 696
Respect oneIndexedParameters property when serialising Page to JSON #3161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
clzola
wants to merge
1
commit into
spring-projects:main
from
clzola:bugfix/page-model-one-index-pagination
Open
Respect oneIndexedParameters property when serialising Page to JSON #3161
clzola
wants to merge
1
commit into
spring-projects:main
from
clzola:bugfix/page-model-one-index-pagination
+77
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...erializing PageImpl
@spring-projects-issues
spring-projects-issues
added
the
status: waiting-for-triage
An issue we've not yet triaged
label
Sep 23, 2024
@mp911de
mp911de
force-pushed
the
main
branch
from
December 2, 2024 08:08
2c56532
to
b2c3623
Compare
@mp911de
mp911de
force-pushed
the
main
branch
2 times, most recently
from
August 18, 2025 07:12
646e077
to
6ac5cf8
Compare
@odrotbohm
odrotbohm
force-pushed
the
main
branch
from
September 2, 2025 08:00
1f86a58
to
3a61461
Compare
@mp911de
mp911de
force-pushed
the
main
branch
from
September 29, 2025 08:13
b0bbaec
to
834368c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed when using Spring Data in my project, I can set property
spring.data.web.one-indexed-parameters
to true and have my page numbering start from 1 in my API. However when returning Page from controller, this value is not respected and it will always return page number decreased by 1.This PR fixes that by adding
oneIndexedParameters
attribute toSpringDataJacksonConfiguration.PageModule
class. I have also addedPageModuleCustomizer
to be used to define wether PageModule will assume 1-based page number indexes in the request parametersIn order to respect this property, a PageModuleCustomizer needs to be defined:
Also this bean can be defined in Spring Boot Autoconfigure project, so spring will automatically take care of this.