Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use inferred destroy method name where feasible #47012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
quaff wants to merge 1 commit into spring-projects:main from quaff:patch-184

Conversation

Copy link
Contributor

@quaff quaff commented Sep 1, 2025

See https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/context/annotation/Bean.html#destroyMethod()

This 'destroy method inference' is currently limited to detecting only public, no-arg methods named 'close' or 'shutdown'.

See https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/context/annotation/Bean.html#destroyMethod()
>> This 'destroy method inference' is currently limited to detecting only public, no-arg methods named 'close' or 'shutdown'.
Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
Copy link
Member

philwebb commented Sep 2, 2025

I think I prefer the explicit declarations for the "shutdown" methods, it helps make it a bit more obvious what's going on.

wilkinsona, snicoll, and bclozel reacted with thumbs up emoji

@philwebb philwebb added the for: team-attention An issue we'd like other members of the team to review label Sep 2, 2025
Copy link
Member

philwebb commented Sep 2, 2025

Looks like the consensus is to keep things as they are. Thanks anyway @quaff!

@philwebb philwebb added status: declined A suggestion or change that we don't feel we should currently apply and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /