-
Notifications
You must be signed in to change notification settings - Fork 41.5k
Autoconfigure redis tracing #46975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoconfigure redis tracing #46975
Conversation
Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>
5455466
to
649dd97
Compare
Thanks for the PR.
The proposed change relates to #46456 and may not be quite right as @mp911de proposed switching from MicrometerCommandLatencyRecorder
to MicrometerTracing
rather than adding the latter alongside the former. In #46456 (comment), I wanted to check if we'd lose anything by always making the switch when ObservationRegistry
is on the classpath.
@mp911de, can you please advise?
This PR doesn't remove MicrometerCommandLatencyRecorder
(which in fact should be done to avoid duplicate metrics for the general case) as per #46456 (comment). Other than that, this is the appropriate change.
@wilkinsona MicrometerCommandLatencyRecorder
is for metrics, and MicrometerTracing
is for tracing.
You can see more docs here
MicrometerTracing
uses the Observation
API that is provided by Micrometer to achieve both, metrics and spans.
Thanks, @mp911de.
@dungdm93, would you like to update your proposal accordingly? Instead of introducing a new LettuceTracingAutoConfiguration
, the existing LettuceMetricsAutoConfiguration
should be updated instead. It should be renamed to LettuceObservationAutoConfiguration
and its content updated to match your proposed LettuceTracingAutoConfiguration
.
Auto-configure
lettuce
tracing which available since lettuce 6.3