Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Autoconfigure redis tracing #46975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dungdm93 wants to merge 1 commit into spring-projects:main
base: main
Choose a base branch
Loading
from dungdm93:redis-tracing

Conversation

Copy link

@dungdm93 dungdm93 commented Aug 28, 2025

Auto-configure lettuce tracing which available since lettuce 6.3

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>
Copy link
Member

Thanks for the PR.

The proposed change relates to #46456 and may not be quite right as @mp911de proposed switching from MicrometerCommandLatencyRecorder to MicrometerTracing rather than adding the latter alongside the former. In #46456 (comment), I wanted to check if we'd lose anything by always making the switch when ObservationRegistry is on the classpath.

@mp911de, can you please advise?

@wilkinsona wilkinsona added the status: waiting-for-internal-feedback An issue that needs input from a member of another Spring Team label Aug 28, 2025
Copy link
Member

mp911de commented Aug 28, 2025

This PR doesn't remove MicrometerCommandLatencyRecorder (which in fact should be done to avoid duplicate metrics for the general case) as per #46456 (comment). Other than that, this is the appropriate change.

Copy link
Author

@wilkinsona MicrometerCommandLatencyRecorder is for metrics, and MicrometerTracing is for tracing.

You can see more docs here

Copy link
Member

mp911de commented Aug 28, 2025

MicrometerTracing uses the Observation API that is provided by Micrometer to achieve both, metrics and spans.

Copy link
Member

Thanks, @mp911de.

@dungdm93, would you like to update your proposal accordingly? Instead of introducing a new LettuceTracingAutoConfiguration, the existing LettuceMetricsAutoConfiguration should be updated instead. It should be renamed to LettuceObservationAutoConfiguration and its content updated to match your proposed LettuceTracingAutoConfiguration.

@wilkinsona wilkinsona added status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-internal-feedback An issue that needs input from a member of another Spring Team labels Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /