-
Notifications
You must be signed in to change notification settings - Fork 41.5k
Support Redis static master-replica auto-configuration #46957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Redis static master-replica auto-configuration #46957
Conversation
Signed-off-by: 용현 <dydguskim@gripcorp.co>
Thanks for the PR.
Given that the static master-replica support is specific to Lettuce, I am not sure that the proposed additions should be as central to the auto-configuration as they currently are. For example, the properties could be nested beneath spring.data.redis.lettuce to indicate that they're only supported with Lettuce.
It also doesn't feel quite right for RedisConnectionDetails to know about a Lettuce-specific feature. I'm not sure how to address this as I don't think we've faced this problem and I don't think we have an established pattern for dealing with it.
I agree. Would it still be consideration if the properties go beneath spring.data.redis.lettuce and make RedisConnectionDetails unaware of this change?
I'd definitely like to see the code in that form please. IMO, it would be an improvement on the current proposal and something that we'd certainly consider.
Hi.
I'd like to suggest support for Redis static Master/Replica auto-configuration.
This auto-configuration makes
LettuceConnectionFactoryuse RedisStaticMasterReplicaConfiguration, e.g. AWS ElastiCache with Replicas.I know it's cautious since Jedis doesn't support for static master-replica connection in Jedis, while Lettuce does.
Please feel free to review this suggestion and share your thoughts.