-
Notifications
You must be signed in to change notification settings - Fork 41.5k
Annotate ApplicationContextAssert methods with @CheckReturnValue #46766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
+17
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@spring-projects-issues
spring-projects-issues
added
the
status: waiting-for-triage
An issue we've not yet triaged
label
Aug 11, 2025
Signed-off-by: Stefano Cordio <stefano.cordio@gmail.com>
@scordio
scordio
force-pushed
the
gh-32683-CheckReturnValue
branch
from
August 11, 2025 07:16
72390fd to
8978e51
Compare
See #32683 (comment)
@snicoll
snicoll
added
the
status: on-hold
We can't start working on this issue yet
label
Aug 11, 2025
As I need to extend Checkstyle's import-control.xml, would it be fine to add a top-level allow statement close to:
<allow class="org.springframework.lang.Contract" />
or should I define a more fine-grained rule, restricting it to the following packages?
org.springframework.boot.test.context.assertjorg.springframework.boot.test.json
would it be fine to add a top-level allow statement close to
Yep. The intention is to restrict only to certain AssertJ entry point and this is one of them so I think that's ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #32683.