-
Notifications
You must be signed in to change notification settings - Fork 2.4k
GH-5006: Fix database connection leak in queryForStream usage #5008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+32
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hyunsang Han <gustkd3@gmail.com>
Oh, I'll rebase and push it soon. It's from outdated main branch 😢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JdbcTemplate::queryForStreamused in try-with-resources blocks causes database connections to close prematurely, leading toDataAccessResourceFailureException: This connection has been closedwhen Hibernate transactions are still active.The
queryForStream()method sets up anonClose()callback that immediately releases the database connection when the Stream is closed, but Hibernate transactions may still need to use the same connection, causing a lifecycle mismatch.I replaced
queryForStreamwithqueryin all affected JDBC DAO classes.Resolves #5006