-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Gh 4755: Fix wrong behavior of JobRepository with empty identifying job parameters #4946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@isanghaessi
isanghaessi
force-pushed
the
GH-4755
branch
from
August 15, 2025 14:25
f7a36ff to
0ce9de6
Compare
@isanghaessi
isanghaessi
force-pushed
the
GH-4755
branch
from
August 15, 2025 14:27
0ce9de6 to
3bcc525
Compare
@isanghaessi
isanghaessi
force-pushed
the
GH-4755
branch
2 times, most recently
from
August 16, 2025 09:03
250bfff to
8954563
Compare
...ob parameters commit 57498c7 Author: Seungyong Hong <jesse1231@naver.com> Date: Sat Aug 16 15:37:35 2025 +0900 Fix wrong behavior of JobRepository with empty identifying job parameters - Update test casese. Signed-off-by: Seungyong Hong <jesse1231@naver.com> commit 4d5a3d6 Author: Seungyong Hong <jesse1231@naver.com> Date: Sat Aug 16 14:44:25 2025 +0900 Fix wrong behavior of JobRepository with empty identifying job parameters - formatting. Signed-off-by: Seungyong Hong <jesse1231@naver.com> commit 0ce9de6 Author: Seungyong Hong <jesse1231@naver.com> Date: Fri Aug 15 23:04:26 2025 +0900 Fix wrong behavior of JobRepository with empty identifying job parameters - simplify brackets. Signed-off-by: Seungyong Hong <jesse1231@naver.com> commit 45efc57 Author: Seungyong Hong <jesse1231@naver.com> Date: Fri Aug 15 20:43:39 2025 +0900 Fix wrong behavior of JobRepository with empty identifying job parameters - Job has to be not completed whether empty identifying job parameters or not. Signed-off-by: Seungyong Hong <jesse1231@naver.com> Signed-off-by: Seungyong Hong <jesse1231@naver.com>
@isanghaessi
isanghaessi
force-pushed
the
GH-4755
branch
from
August 16, 2025 09:13
8954563 to
0142d11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Summary
This PR fixes #4755 .
Problem is, job with having zero identifier job parameters are able to restart.
Job what having COMPLETED status should not be able to restart with same Job Parameters.
Changes