-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Refactor JobKeyGenerator to use JobParameters instead of generic type #4887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
patrickwinti
wants to merge
1
commit into
spring-projects:main
from
patrickwinti:jobparameters-jobkeygenerator
Closed
Refactor JobKeyGenerator to use JobParameters instead of generic type #4887
patrickwinti
wants to merge
1
commit into
spring-projects:main
from
patrickwinti:jobparameters-jobkeygenerator
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Schwizer <schwizer.p@proton.me>
LGTM 👍 Rebased and merged as b1e4a94. Thank you for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
The JobKeyGenerator interface currently uses a generic type parameter to represent the source used to generate a job key. However, in practice, all known implementations and usages of this interface rely specifically on JobParameters as the source type.
resolves #4886