-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Fail test if no exception is thrown in testErrorMessageWhenNoLineTokenizerWasProvided
#4883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fmbenhassine
merged 1 commit into
spring-projects:main
from
martinfrancois:gh-throwerror-test
Jun 13, 2025
Merged
Fail test if no exception is thrown in testErrorMessageWhenNoLineTokenizerWasProvided
#4883
fmbenhassine
merged 1 commit into
spring-projects:main
from
martinfrancois:gh-throwerror-test
Jun 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...enizerWasProvided` Signed-off-by: martinfrancois <f.martin@fastmail.com>
@martinfrancois
martinfrancois
force-pushed
the
gh-throwerror-test
branch
from
June 13, 2025 14:51
624e66d to
bff4698
Compare
@fmbenhassine
fmbenhassine
merged commit Jun 13, 2025
639d64f
into
spring-projects:main
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Currently, if the builder method doesn't throw an exception, the test would still pass.
Instead of adding a
fail()after the builder call, I refactored it to be consistent with the other tests for exceptions.