Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Migrate spring-batch-infrastructure to JSpecify annotations #4864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
scordio wants to merge 2 commits into spring-projects:main
base: main
Choose a base branch
Loading
from scordio:jspecify

Conversation

Copy link
Contributor

@scordio scordio commented Jun 8, 2025 •
edited
Loading

This change also introduces NullAway to verify @NullMarked annotated packages.

This also includes the changes from #4959, but I'll rebase this PR once that one is merged.

@scordio scordio force-pushed the jspecify branch 7 times, most recently from 35c9da1 to c737967 Compare June 13, 2025 08:45
@scordio scordio force-pushed the jspecify branch 2 times, most recently from 38292b1 to fee88d7 Compare June 21, 2025 17:08
@scordio scordio force-pushed the jspecify branch 2 times, most recently from 8e2edf2 to abeb820 Compare June 25, 2025 03:11
Copy link
Contributor

This is a huge amount of work.. thank you very much for contributing this PR! I REALLY appreciate your time and effort on this 🙏

I am targeting the migration to jSpecify for v6.0.0-M3 (planned for Sep 17th), so I will start working on this right after releasing 6.0.0-M2. I see that the PR is still in draft status, which is ok, but is there a module I can I start reviewing?

Just as a (self) reminder, we need to get rid of the com.google.code.findbugs:jsr305 dependency as part of this.
scordio reacted with thumbs up emoji

Copy link
Contributor Author

scordio commented Aug 20, 2025 •
edited
Loading

Hi @fmbenhassine, I couldn't spend time on it in the last weeks, but I'll be able to get back to it this week and make sure it'll be in the right shape in time for M3 (including giving you time for review, of course 🙂)

So far, I approached it by executing the full build and addressing the problems in a mostly sequential order. I'll rebase my branch and see if I can split the changes into smaller PRs so that the review becomes easier.
fmbenhassine reacted with heart emoji 

Signed-off-by: Stefano Cordio <stefano.cordio@gmail.com>
@scordio scordio changed the title (削除) Migrate to JSpecify annotations for nullability constraints (削除ここまで) (追記) Migrate spring-batch-infrastructure to JSpecify annotations (追記ここまで) Aug 21, 2025
Copy link
Contributor Author

scordio commented Aug 21, 2025 •
edited
Loading

@fmbenhassine I'm reducing the scope of this PR to spring-batch-infrastructure for a simpler review (I guess you could remove some labels), and I'll raise separate PRs for the other modules.

(as you wisely proposed in the past 🙃)

@scordio scordio force-pushed the jspecify branch 6 times, most recently from dfd06e7 to be5225b Compare August 26, 2025 12:16 
Signed-off-by: Stefano Cordio <stefano.cordio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /