Fix javadoc in JdbcCursorItemReaderBuilder #4838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

fmbenhassine merged 1 commit into spring-projects:main from itis821:fix-itemreader-javadoc

Jun 3, 2025

Merged

Fix javadoc in JdbcCursorItemReaderBuilder #4838

fmbenhassine merged 1 commit into spring-projects:main from itis821:fix-itemreader-javadoc

Jun 3, 2025

Conversation

itis821

Copy link

Contributor

@itis821 itis821 commented May 8, 2025

JdbcCursorItemReaderBuilder.queryTimeout(int) -> milliseconds
but, AbstractCursorItemReader.setQueryTimeout(int) -> seconds

@itis821


 Fix javadoc in JdbcCursorItemReaderBuilder

3d20632

 - JdbcCursorItemReaderBuilder.queryTimeout(int) -> milliseconds
 - but, AbstractCursorItemReader.setQueryTimeout(int) -> seconds
Signed-off-by: Jisu Lee <itis821@gmail.com>

@itis821

Copy link

Contributor Author

itis821 commented May 8, 2025

JdbcCursorItemReaderBuilder's build() method calls JdbcCursorItemReader.setQueryTimeout(int). This setQueryTimeout(int) method is actually defined in AbstractCursorItemReader.setQueryTimeout(int). Therefore, the queryTimeout parameter from JdbcCursorItemReaderBuilder is passed as an argument to AbstractCursorItemReader.setQueryTimeout(). However, there's an issue where the javadoc specifies different units for this timeout value between JdbcCursorItemReaderBuilder and AbstractCursorItemReader.