-
Notifications
You must be signed in to change notification settings - Fork 2.4k
GH-4703: Enhance StoppableTasklet interface to support step-specific stop requests #4715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4e731cb to
c9365d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new method provides a default implementation that delegates the call to the existing stop() method, ensuring backward compatibility for implementations that do not need step-specific stopping logic.
If you have any suggestions for improvement, please feel free to provide feedback!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great! We just need to mark the current stop method as deprecated. I will take care of that on merge.
c9365d3 to
f3f2b85
Compare
f3f2b85 to
30ba4e3
Compare
- Deprecate stop method - Fix imports - Update Javadocs
Closes: #4703
Resolves a limitation in the
StoppableTaskletinterface where distinguishing which specific StepExecution to stop was not possible during concurrent job executions.