Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add delete cascade on metadata tables' foreign keys #4584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mayleaf wants to merge 1 commit into spring-projects:main
base: main
Choose a base branch
Loading
from mayleaf:delete_cascade_on_foreign_keys

Conversation

Copy link

@mayleaf mayleaf commented May 5, 2024

Solved #4555

  • Motivation
    On DELETE CASCADE on Foreign Keys #4555 , We found delete methods in SimpleJobRepository are removing with separated SQL queries for each metadata tables
  • Modification
    Add ON DELETE CASCADE to each metadata tables' foreign keys.

injae-kim reacted with thumbs up emoji injae-kim reacted with heart emoji
Copy link

@mayleaf Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

Copy link

@mayleaf Thank you for signing the Contributor License Agreement!

@@ -135,8 +135,17 @@ public void removeJobExecutions(Collection<JobExecution> jobExecutions) {
for (JobExecution jobExecution : jobExecutions) {
Copy link
Author

@mayleaf mayleaf May 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I delete this method since it's no longer used after this pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /