Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update missing information about error handling in ChunkListener doc #4490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Copy link
Contributor

@injae-kim injae-kim commented Nov 17, 2023
edited
Loading

related issue #4384

Motivation:

Chunk listeners are not designed to throw exceptions. 
Exceptions must be handled in the implementation or the step will terminate. 
This is mentioned in the javadoc of TerminateOnExceptionChunkListenerDelegate, but this class is private.
  • We found that ChunkListener is designed to not throw exception, but this important details is missing on ChunkLisnter doc now, only on private class TerminateOnExceptionChunkListenerDelegate.

Modification:

  • Update missing information about error handling in ChunkListener doc

Result:

Comment on lines +331 to +332
@Test
void testChunkListeners_thrown_terminate_step() throws Exception {
Copy link
Contributor Author

@injae-kim injae-kim Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

	@Test
	void testChunkListeners() throws Exception {

FYI, mostly just copy&paste from exist test on L249 ~!

Copy link
Contributor

Rebased and merged as 74c0b27. I just amended the missing information in the reference docs as well. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing information about error handling in ChunkListeners

AltStyle によって変換されたページ (->オリジナル) /