-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Update missing information about error handling in ChunkListener doc #4490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
injae-kim
wants to merge
1
commit into
spring-projects:main
from
injae-kim:update-chunk-listener-missing-doc
Closed
Update missing information about error handling in ChunkListener doc #4490
injae-kim
wants to merge
1
commit into
spring-projects:main
from
injae-kim:update-chunk-listener-missing-doc
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injae-kim
injae-kim
commented
Nov 17, 2023
Comment on lines
+331
to
+332
@Test
void testChunkListeners_thrown_terminate_step() throws Exception {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Test void testChunkListeners() throws Exception {
FYI, mostly just copy&paste from exist test on L249 ~!
Rebased and merged as 74c0b27. I just amended the missing information in the reference docs as well. Thank you for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
related issue #4384
Motivation:
ChunkListener
is designed to not throw exception, but this important details is missing onChunkLisnter
doc now, only on private classTerminateOnExceptionChunkListenerDelegate
.Modification:
ChunkListener
docResult:
ChunkListener
is designed to now throw exception or step will terminate by javadoc