-
Notifications
You must be signed in to change notification settings - Fork 269
Add libicu dependency to RPM spec file #781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(cherry picked from commit f312895ef8c77098612645a54420539fef70a849)
(削除) I am aware of this, but I strongly oppose this change. There is no icu package that rpm-compatible distros share. The correct solution is to rely on .so.
You need to check which sonames of icu dotnet 9 supports and combine them with or in Requires:. This is the reason I did not bother with this, because icu is almost always installed on a machine with a graphical desktop environment and dotnet will dynamically find compatible .so. (削除ここまで)
You also need to test this change with at least openSUSE and CentOS (assuming fedora passed). There has also been report from obscure ALT Linux distribution not so long ago with similar dependency issue, wouldn't hurt to check it there too.
Oh. Did not expected so much work(
Ok, I'll try
I checked RHEL9, almalinux9, rockylinux9,opensuse, centos9. ALT linux seems to be not rpm-based.
For the sanity I used distrobox (docker-based distro containers), and pre-built packages may differ with default ones on full distro, but this is not important because what we want to check is that libicu is resolved correctly.
ALT linux seems to be not rpm-based.
It uses apt-rpm
There is no icu package that rpm-compatible distros share. The correct solution is to rely on .so.
That was a false memory. That's .deb thing 😁
For rpms libicu is fine
There is no icu package that rpm-compatible distros share. The correct solution is to rely on .so.
That was a false memory. That's .deb thing 😁 For rpms
libicuis fine
Ahhh, only after such long testing...
Ok. And altlinux can go to hell 👀
[root@60cc9e845464 sourcegit]# apt-get install build/sourcegit-0.0.3-1.x86_64.rpm
Reading Package Lists... Done
Building Dependency Tree... Done
Selecting sourcegit for 'build/sourcegit-0.0.3-1.x86_64.rpm'
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
Since you only requested a single operation it is extremely likely that
the package is simply not installable and a bug report against
that package should be filed.
The following information may help to resolve the situation:
The following packages have unmet dependencies:
sourcegit: Depends: libc.so.6(GLIBC_2.34)(64bit) but it is not installable
E: Broken packages
[root@60cc9e845464 sourcegit]# ^C
[root@60cc9e845464 sourcegit]# apt-get install build/sourcegit_0.0.3-1_amd64.deb
Reading Package Lists... Done
Building Dependency Tree... Done
E: Couldn't find package build/sourcegit_0.0.3-1_amd64.deb
[root@60cc9e845464 sourcegit]# apt-get install build/sourcegit_0.0.3-1_amd64.deb
Reading Package Lists... Done
Building Dependency Tree... Done
E: Couldn't find package build/sourcegit_0.0.3-1_amd64.deb
The following packages have unmet dependencies: sourcegit: Depends: libc.so.6(GLIBC_2.34)(64bit) but it is not installable
Now sourcegit's CI uses Debian 11 for release, so glibc >= 2.29 is sufficient. The glibc version required by the application depends on the environment at compile time.
@love-linger target branch of this PR seems wrong.
This reverts commit 6621490.
(cherry picked from commit f312895ef8c77098612645a54420539fef70a849) (cherry picked from commit 6621490)
I discovered that on modern fedora 41 sourcegit rpm package does not install
libicudependency, which leads to crash when trying to launch an app:Note:
build/sourcegit-0.0.1-1.x86_64.rpmpackage is built from latest changes on dev branchThis PR adds
libicuas explicit dependency. Tested manually, newly built rpm package works fine.