-
Notifications
You must be signed in to change notification settings - Fork 268
Enhance German translation (2) #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
+ fix some typos and add missing translations
Hi @NilsPvR,
thank you for the improvements and thorough preparation (comments) of this PR!
I'm done reviewing. I left some comments but hopefully they are helpful for you!
492859f
into
sourcegit-scm:develop
Hey @warappa, thanks for the extensive review and all the added sources 💪. Was quite busy yesterday so I went through the comments now. I'll make a new PR once the last suggestions are resolved, since this PR is already merged.
Hi @NilsPvR, I think I'm through again. Thank you for the good collaboration! 👍
As mentioned in the issue I went through the German translations and found some things which could be improved. I'll add a review to this PR to comment on my suggestions for the translations. I won't add any comments on the simple typos.
A code review by @warappa would be greatly appreciated.
Fixes #331