-
Notifications
You must be signed in to change notification settings - Fork 267
Make the side panel scroll as a whole #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the side panel scroll as a whole #237
Conversation
...ll screens when repo has lots of tags and branches
If whole panel is scrollable, virtualizing will not work. This can cause stalling when displaying a large number of lists or tree nodes.
Firstly the tags are not shown by default. Secondly they can always filter first, if they really have THAT many tags.
My main complatination is even ignore the tags, currently the branch list cannot be properly used on small screens.
At the moment, if you have a lot of local branches, you couldn't even see the remotes list nor submodules, not mention tags.
image
At the moment, if you have a lot of local branches, you couldn't even see the remotes list nor submodules, not mention tags. image
This is indeed a disaster.
For a redesign, I would focus on two things
- Need to support virtualization so that it doesn't get stuck when there are many items
- Each group should be easily found at any time. For example, if you are scrolling through a list with 1000+ tags, you should also be able to see the grouping of local branches in that state, rather than having to scroll back.
At the moment, if you have a lot of local branches, you couldn't even see the remotes list nor submodules, not mention tags. image
This is indeed a disaster.
For a redesign, I would focus on two things
- Need to support virtualization so that it doesn't get stuck when there are many items
- Each group should be easily found at any time. For example, if you are scrolling through a list with 1000+ tags, you should also be able to see the grouping of local branches in that state, rather than having to scroll back.
Yeah agreed.
I've pushed a new implementation for this. You can try it with latest develop branch
I've pushed a new implementation for this. You can try it with latest develop branch
That's much better now! Thanks! I can daily drive this instead of SourceTree now~ Fantastic work man!
I've pushed a new commit for this feature. You can try the latest build
This works much better on small screens when repo has lots of tags and branches
side_scroll