-
Notifications
You must be signed in to change notification settings - Fork 267
code_style: general cleanup #1565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I no longer plan to merge this kind of PR.
- There are too many code changes, which takes too much time to review.
- Sometimes I can't recall the issues that needed to be considered during the coding process, resulting in bugs, such as 2025.26 Can't
UNSTAGE
files fromstage
when checkedAmend
checkbox #1582 , 2025.26 doesn't startup if the path has a space in it. #1576 , d28bd92, etc. - Most of them are about new syntax or variable initialization suggestions.
No worries, I only submitted this because you were so quick and thorough at reviewing previous cleanup PRs. I wasn't aware there had been regressions.
@love-linger
love-linger
force-pushed
the
develop
branch
6 times, most recently
from
July 21, 2025 09:52
05dba32
to
6822ae3
Compare
@love-linger
love-linger
force-pushed
the
develop
branch
3 times, most recently
from
July 28, 2025 13:30
072502a
to
5ce919a
Compare
@love-linger
love-linger
force-pushed
the
develop
branch
5 times, most recently
from
August 19, 2025 07:54
f325aaf
to
6511d15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Various code improvements. The changes to
QueryLocalChanges
in particular make the code much easier to understand.