-
Notifications
You must be signed in to change notification settings - Fork 267
[Feature] Keep tree state and selection in 'Files' tab when changing commit in history #1396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Keep tree state and selection in 'Files' tab when changing commit in history #1396
Conversation
- The directory structures may vary for different revisions.
- Expanding a folder tree node means running the command
git ls-tree -z <REVISION> -- <FOLDER_PATH>once. This will seriously affect the response speed of the entire interface. If the hierarchy is too deep, it may even cause the interface to freeze. - For the need to view the changes of the same file under different revisions, it is recommended to use the
File Historiesfeature.
- The directory structures may vary for different revisions.
That is taken care of quite gracefully in this PR, by simply losing the selection (while still keeping the parent folder(s) expanded, if possible).
- Expanding a folder tree node means running the command
git ls-tree -z <REVISION> -- <FOLDER_PATH>once. This will seriously affect the response speed of the entire interface. If the hierarchy is too deep, it may even cause the interface to freeze.
I don't see a big slowdown even several levels deep in a folder with lots of files. (If this is an issue, we could have an option "Preserve selection in file-tree" or similar.)
- For the need to view the changes of the same file under different revisions, it is recommended to use the
File Historiesfeature.
That is not really the same thing, since this feature also shows the selected file in context at its path in the repo.
Having to drill down repeatedly to the same subfolder hierarchy each time another Commit gets selected is simply frustrating, and it makes the FILES view less useful than it could be.
5ca1567 to
f657847
Compare
05dba32 to
6822ae3
Compare
072502a to
5ce919a
Compare
this is usefull
... 'Files' tab when switching between commits.
633242b to
4d9069b
Compare
Rebased the branch, to work with the newer async handling. May need some extra work just to remove "flickering" when re-expanding file-tree levels (should be done all-at-once before re-displaying tree).
599832a to
876e2a3
Compare
f325aaf to
6511d15
Compare
In the 'Files' tab for commit history window when previewing the selected file you lose the selection and expand state of all the nodes when selecting a new commit. It would be nice to keep the selection (if possible) when jumping between commits, for a quick glace of the changes made in a single file.
This PR aims to keep the selected item and update the preview to the new commit.