-
Notifications
You must be signed in to change notification settings - Fork 269
[Feature] Added missed LFS Image cases to file browser and file history #1395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Added missed LFS Image cases to file browser and file history #1395
Conversation
NOTE: This PR is a follow-up to previous PR #1386.
Sorry. I need to re-write all codes to detect lfs pointer and image loading.
@love-linger - Currently there's a discrepancy / inconsistency between the Diff and Files views. We should be able to view an LFS image File as IMAGE, just like we are (since recently) able to view an LFS image Diff as IMAGE.
Can you please explain the future of the suggested fix from this PR? Do you intend to implement it, but in a slightly different way? (If so, could you add an issue so we can track its progress?)
Also, what was bad about the suggested implementation?
I mean I've rewrite the codes about lfs pointers detection and image loading. And this request has been added in my code. See latest develop branch.
Ah, sorry - I missed that this was addressed in commit a023a92. (It's harder to follow updates when the related PR is not referenced in the commit.)
Uh oh!
There was an error while loading. Please reload this page.
I tried to follow in the style of the LFSDiffView from
ed496a4. Possibly the function BitmapFromLFSObject could be moved somewhere more appropriate to be able to reuse it instead of changing its access modifier