-
Notifications
You must be signed in to change notification settings - Fork 268
fix: Copy in TextDiffView may lost the last line #1044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...lines in text diff view (#1044) Signed-off-by: leo <longshuang@msn.cn>
I've pushed another fix for this issue. See commit 35ee4a4
image
I think that make the issue worse.
Very strange.
image
The reason of this issue is:
When clamp startIdx
and endIdx
to [0, lines.Count - 1]
, the endPosition.Column
and startPosition.Column
may no longer refer to the row corresponding to endIdx
/startIdx
I can not re-produce the issue shows in your picture.
Run from the code is fine, but the artifacts in CI seems not right.
Try to use Copy
context menu instead of hotkey Ctrl+C
which sometimes did not work as expacted.
Try to use
Copy
context menu instead of hotkeyCtrl+C
which sometimes did not work as expacted.
With the CI artifacts, the copy in context menu also not right, that's weird. I'm using Deepin 23 with linux-x64
I'll download it and try
Strange. The package.win-x64.zip
works as expacted on my PC.
Please make sure you have downloaded the correct version:
image
I am sure that I downloaded linux-x64 from https://github.com/sourcegit-scm/sourcegit/actions/runs/13625760977, and run dotnet publish
locally will also produce the effect shown in the picture.
Can you debug this project now?
After I reinstalled the deb/copied the locally packaged files several times, it finally worked, and I had no idea what the problem was.
Currently, copy would append an extra empty line if more than one line is selected.
Currently, copy would append an extra empty line if more than one line is selected.
It's because that for multiple lines selection, we use StringBuilder.AppendLine
which will always add a line-ending character for each line.
I made #1049 to fix this.
Uh oh!
There was an error while loading. Please reload this page.
Reproduce: Press
Ctrl + A
inTextDiffView
and copy