-
Notifications
You must be signed in to change notification settings - Fork 207
Updated to BookStack v0.11.1 & php7 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your PR 💖 . For me it's okay when we use PHP 7 instead of 5. I want to be only as closely as possible to the official repository. So If you say that use PHP 7 for your own setup than i will switch to it. I will test it later and after that I will merge this.
It works for me. I will merge this now. 👍
acomdigital
added a commit
to acomdigital/docker-bookstack
that referenced
this pull request
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was just trying out your Docker image for BookStack. Thought I'd update it to the latest recent bugfix release and also update to PHP 7 to gain the performance improvement.
Awesome docker image by the way, I tried before but just failed as I had trouble orchestrating containers. Your docker-compose setup just worked right away, Was awesome to see work on the first
docker-compose upwithout any issues.