Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

refactor: 게시글 조회 응답에 댓글 deprecated 여부 포함하도록 #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
whqtker wants to merge 1 commit into solid-connection:develop
base: develop
Choose a base branch
Loading
from whqtker:refactor/499-include-comments-are-deprecated-or-not

Conversation

@whqtker
Copy link
Member

@whqtker whqtker commented Dec 29, 2025 •
edited
Loading

관련 이슈

작업 내용

게시글 조회 시 댓글 deprecated 여부 포함 요청하셔서 응답에 필드 추가했습니다 !

특이 사항

리뷰 요구사항 (선택)

Copy link

coderabbitai bot commented Dec 29, 2025 •
edited
Loading

워크스루

PostFindCommentResponse 레코드에 새로운 Boolean isDeleted 필드가 추가되었습니다. 이에 따라 정적 팩토리 메서드인 from(...)도 업데이트되어 소스 Comment 객체의 isDeleted() 값을 새로 추가된 필드로 전달합니다.

  1. 새로운 공개 필드 추가
    • Boolean isDeleted 필드가 레코드에 도입됨
  2. 팩토리 메서드 업데이트
    • from(...) 메서드가 comment.isDeleted() 값을 전달하도록 수정됨
  3. 공개 API 변화
    • PostFindCommentResponse의 공개 인터페이스에 isDeleted 속성이 노출됨

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • Hexeong
  • lsy1307
  • JAEHEE25

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check ❓ Inconclusive PR 설명에서 관련 이슈와 작업 내용은 기재되었으나, 특이 사항과 리뷰 요구사항 섹션이 완전히 공백으로 남아있습니다. 프로젝트 실행에 미치는 영향(Breaking Change 여부, 마이그레이션 필요성 등)과 리뷰 중점 사항을 명시해 주세요.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed PR 제목이 핵심 변경사항을 명확하게 요약하고 있습니다: 게시글 조회 응답에 댓글의 deprecated 여부를 포함하는 것.
Linked Issues check ✅ Passed 코드 변경사항이 이슈 #499의 목적(댓글의 deprecated 여부 포함)을 충족하고 있으나, 이슈의 상세 작업 항목이 TODO만 표기되어 검증이 제한적입니다.
Out of Scope Changes check ✅ Passed 변경사항이 PostFindCommentResponse에 isDeleted 필드 추가로 단일하며, 이슈 #499의 범위를 벗어나는 변경사항이 없습니다.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gyuhyeok99 Gyuhyeok99 Awaiting requested review from Gyuhyeok99 Gyuhyeok99 is a code owner

@wibaek wibaek Awaiting requested review from wibaek wibaek is a code owner

@lsy1307 lsy1307 Awaiting requested review from lsy1307 lsy1307 is a code owner

@Hexeong Hexeong Awaiting requested review from Hexeong Hexeong is a code owner

@JAEHEE25 JAEHEE25 Awaiting requested review from JAEHEE25 JAEHEE25 is a code owner

@sukangpunch sukangpunch Awaiting requested review from sukangpunch sukangpunch is a code owner

At least 1 approving review is required to merge this pull request.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

refactor: 특정 게시글 조회 시 댓글 deprecated 여부를 포함하도록

1 participant

AltStyle によって変換されたページ (->オリジナル) /