-
Notifications
You must be signed in to change notification settings - Fork 5
Merged
Conversation
기존 release.yml은 머지된 PR이 composer.json 버전을 직접 bump하지 않으면 태그 충돌로 모든 release step이 skip되어 "성공"으로만 끝나는 한계가 있었다. master push 시 conventional commits를 분석해 버전 bump Release PR을 자동 생성하고, 해당 PR이 머지되면 태그·GitHub Release를 자동 발행하도록 변경한다. - .github/release-please-config.json: simple release-type, composer.json은 jsonpath updater, src/Models/Request/DefaultAgent.php는 generic updater - .github/.release-please-manifest.json: baseline 5.1.2 - .github/workflows/release-please.yml: master push 트리거 - DefaultAgent.php: x-release-please-version 마커 주석 추가 - 기존 release.yml 제거 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces automated versioning and changelog management by adding release-please configuration and manifest files. It also updates DefaultAgent.php with a version comment to allow the tool to track and update the SDK version. The reviewer suggested changing the release-type to php in the configuration, which would simplify the setup by automatically handling composer.json updates.
release-please의 PHP strategy는 RootComposerUpdatePackages 업데이터로 composer.json의 version 필드를 자동 관리하고 jsonStringify 헬퍼로 원본 포맷을 보존한다. jsonpath updater를 별도로 두는 것보다 PHP 전용 처리가 더 안전하고 의도가 명확하다. - release-type: "simple" → "php" - extra-files에서 composer.json 항목 제거 (PHP strategy가 자동 처리) - DefaultAgent.php generic updater는 유지 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@Palbahngmiyine
Palbahngmiyine
merged commit May 11, 2026
e50e932
into
solapi:master
10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
composer.json버전을 직접 bump하지 않으면 v5.1.2 태그 충돌로 모든 release step이 skip되어 "성공"으로만 끝나는 한계가 있었음 (예: run 25643942728)Changes
.github/release-please-config.json:simplerelease-type,composer.json은 jsonpath updater,src/Models/Request/DefaultAgent.php는 generic updater.github/.release-please-manifest.json: baseline5.1.2.github/workflows/release-please.yml: master push 트리거,googleapis/release-please-action@v4DefaultAgent.php:x-release-please-version마커 주석 추가 (같은 줄의X.Y.Z를 자동 교체).github/workflows/release.yml제거Expected flow after merge
fix: harden response mapping edge cases커밋을 인식composer.json·DefaultAgent.php·CHANGELOG.md·manifest 동시 업데이트)v5.1.3태그 + GitHub Release 자동 발행Test plan
release-please워크플로가 실행되어 "chore(main): release 5.1.3" PR이 자동 생성되는지 확인🤖 Generated with Claude Code