-
Notifications
You must be signed in to change notification settings - Fork 156
Fix Iceberg incremental read option conflict detection - #4302
Open
fallintoplace wants to merge 1 commit into
Open
Fix Iceberg incremental read option conflict detection #4302fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
fallintoplace
requested review from
sfc-gh-aling,
sfc-gh-jzeng and
sfc-gh-yixie
August 2, 2026 00:14
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.
I have read the CLA Document and I hereby sign the CLA
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.
fallintoplace
commented
Aug 2, 2026
Author
I have read the CLA Document and I hereby sign the CLA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
version_ref,branch, andtagreader optionsDataFrameReader.option()stores keys in uppercase, while the incremental-read detector compared those keys against lowercase values. As a result, the detector returned early and allowed time-travel options to be silently ignored when incremental reads were configured.Testing
python -m pytest tests/unit/test_utils.py -qpre-commit run --files src/snowflake/snowpark/dataframe_reader.py tests/unit/test_utils.py